Hi Clay.
Here are my comments on installadm_common.py.
Thanks,
Jack
4-92: Use of the newlineFn, commentFn and blanklineFn dictionaries with
"eval" can be quite confusing. It would be clearer to me to use lambda
functions or even if-else constructs. (Yes, it's a little longer, but
would be a lot clearer.)
102: indentation. Pep8 suggests using () instead of \, so 102 can be
aligned with the opening ( .
Note: Sorry to be such a pain about indentation, but I have a problem
with continuation lines being indented the same as the next nesting level.)
272: extra "a"
304: Add "for example" to this comment please.
339 - 344: I would put this code near the top of the class, as it's part
of the object's initialization, correct?
725: typo wil -> will
