Susan Sohn wrote: > Hi Evan, > > be_rename.c > ----------- > 114-130 I'd move these newly added lines to line 96. It seems like you > should > check that the rename is even possible, before verifying that the new BE > name is valid.
Good point. moved. > > 122 (nit) add a blank line done Thanks for looking at the changes! -evan > > Sue > > Evan Layton wrote: >> Hi, >> >> I need to get a review the following fix. This simply adds a check >> to see if we're attempting to rename the current BE and if so we >> return a more appropriate error. >> >> 3332 beadm rename error message remains unhelpful >> http://defect.opensolaris.org/bz/show_bug.cgi?id=3332 >> >> Webrev: >> http://cr.opensolaris.org/~evanl/3332/ >> >> Thanks! >> -evan >> _______________________________________________ >> caiman-discuss mailing list >> caiman-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >
