Karen Tung wrote: > Hi Jean, > > Thank you for the code review. See my responses below. > > Jean McCormack wrote: >> finalizer_checkpoint.py: Since simple_log_name and detail_log_name >> are no longer used the setting of them from the >> arguments should be removed. They shouldn't even be passed in. >> finalizer_rollback.py: ditto. > Yes, you are right. Will remove them. Also fixed up the functions in > DC_checkpoint.py and distro_const.py that pass > these arguments in. >> >> install_utils.py: lines 402 and 404: Remove the "be" > Fixed >> line 460 & 479: what happens if output[-1:] isn't "\n"? It looks like >> it wouldn't get written out. I'm curious as to why you'd want that. > if output[-1:] isn't "\n", the output gets accumulated in the > stdout_buf or stderr_buf in 446 and 470. > I only want to write out to the log when \n is seen because some > commands prints multiple messages > on the same line. If I write out each message as I read them, the > output will get messed up, which is > what bug 4448 is reporting. I have added some comments to the updated > webrev. Do you think the > comments explains my reasoning better? I get it now. Looks good!
Jean > > The updated webrev is at: > > http://cr.opensolaris.org/~ktung/4448_5492_updated/ > > Thanks, > > --Karen > >> >> >> Jean >> >> >> Karen Tung wrote: >>> Please review the changes for the following 2 bugs: >>> >>> 5492 slim_install is left unremoved after installation with global >>> (babel) CD >>> 4448 DC seems to mangle the log files a bit >>> >>> webrev: >>> >>> http://cr.opensolaris.org/~ktung/4448_5492/ >>> >>> Thanks, >>> >>> --Karen >>> _______________________________________________ >>> caiman-discuss mailing list >>> caiman-discuss at opensolaris.org >>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >>> >> >
