Hi Jan, Thank you very much for the code review.
> the fix looks good to me. > > I have some generic comments. If they might > be valid, we could just file new bugs for > tracking them. > > Looking at installadm(1M) man page, it looks > like only one name-value pair can be specified > by -b option. Is this the case or could I specify > more than one property ? Yes, more than one is ok as David pointed out in a subsequent email. I will ask Barbara to update the man page. > It seems that this feature is currently only > implemented for x86 platform. I think we will need > this also for Sparc. > For example, if I would like to enable ssh in AI > environment along with turning on debug mode, > I might just specify something like > "-b enable_ssh=true,install_debug=true" when configuring > particular client. > Do you think that taking advantage of '-b' for such > kind of things is the right approach or another > mechanism should be developed for passing user > arguments to AI client ? It might be. We'd have to investigate how to best implement that. I filed bug 6442 to track this. Thanks again, Sue > Thank you, > Jan > > > Sue Sohn wrote: >> Please review the changes for: >> >> 6388 create-client -b option should be supported >> http://defect.opensolaris.org/bz/show_bug.cgi?id=6388 >> >> which are posted at: >> >> http://cr.opensolaris.org/~sohn/6388 >> >> Thanks, >> Sue >> _______________________________________________ >> caiman-discuss mailing list >> caiman-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss > > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
