Hi Padraig,
I agree with Joanmarie. The rest LGTM.
best
Michal
Joanmarie Diggs wrote:
> Hi Padraig.
>
> With respect to this:
>
> name_renderer = gtk.CellRendererText()
> + name_renderer.set_property("editable", True)
> + name_renderer.connect('edited', self.__be_name_edited, model)
> column = gtk.TreeViewColumn(_("Boot Environment"),
> name_renderer, text = BE_NAME)
> column.set_cell_data_func(name_renderer,
> self.__cell_data_function, None)
>
> Instead of setting editable here, could you create a method similar to
> __cell_data_default_function and set the editable property based on
> whether or not the row is marked/currently active?
>
> Take care.
> --Joanie
>
> On Wed, 2009-02-11 at 11:18 +0000, Padraig O'Briain wrote:
>> The webrev http://cr.opensolaris.org/~padraig/ips-4698-v1/ fixes
>> 4698 Boot environment manager doesn't support rename of BE
>>
>> The cells in the GtkTreeView containing the BE names are made editable.
>> When the user edits a name, we call beVerifyBEName from libbe to check
>> that the proposed name is valid and then call beRename from libbe to
>> change the name.
>>
>> If beVerifyBEName fails we display an error message that the BE name is
>> invalid in an error dialog.
>> If beRename fails we display the error text corresponding to the return
>> code in an error dialog.
>>
>> Padraig
>> _______________________________________________
>> pkg-discuss mailing list
>> pkg-discuss at opensolaris.org
>> http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
>
> _______________________________________________
> pkg-discuss mailing list
> pkg-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
