Ethan Quach wrote: > >> >> - The above two imply that criteria could be administered >> subsequent to a manifest being published. Given that criteria are >> an external entity from the actual install manifest (the ai_manifest), >> I think this makes sense. Perhaps we add a couple new >> subcommands to enable this? (This assumes that the list of 'criteria' >> is an interface we export, and is not customizable. I didn't see >> anything in the design doc to say otherwise.) >> >> installadm set-criteria -n <svcname> -m <manifest_name> name=value >> >> installadm get-criteria -n <svcname> -m <manifest_name> [name] >> >> >> - Be able to view the contents of a published manifest. Perhaps: >> >> installadm export-manifest -n <svcname> -m <manifest_name> [-o file] >> >> >> - Being able to edit the attributes of a published manifest would >> seem like a natural follow-on to the above, but I don't have any >> evidence yet that this is required. Given the ability to export the >> contents of a manifest, it should suffice for now to just export a >> manifest to file, make edits, and re-publish. > > If a manifest gets republished (i.e. we readd a manifest to a service > that already has that manifest name), we'll check if the criterion > for the already published manifest matches that of the one being > added. If they differ, ask user which one they want. It would probably be a good idea to do this only if the current manifest has been altered using the set-criteria command so that the user is queried only when appropriate. Perhaps a flag could be set in the current manifest by the set-criteria command... > ... > > > For all of the installadm subcommands, the main operand shouldn't > need an option identifier. For example, > > installadm list -n <svcname> > > should be > > installadm list <svcname> Since all installadm subcommands, except delete-client, help, and version, require svcname I suggest that it be made an operand for all commands and all other arguments be options. For backward compatiblity -n svcname could continue to be accepted. "Installadm help subcommand" would not be affected. "Delete-client mac_addr" would be changed to "delete-client -e mac_addr" to be consistent with "create-client -e mac_addr ..." and the use of svcname as the only command operand.
Frank
