Glenn Lagasse wrote: > Could I get a reviewer (or more) to have a look at the changes I'm > proposing for 5265 (Distro constructor should auto-generate image > hashes) please? > > http://defect.opensolaris.org/bz/show_bug.cgi?id=5265 > http://cr.opensolaris.org/~glagasse/slim_source/ > > In case anyone is curious, I'm generating MD5, SHA-1 and SHA-256 > cryptographic hashes. SHA-256 may be a little overkill but it's *more > secure* than the others and I figured I'd try and appease the security > conscious crowd while I was at it (SHA-256 checksums are also starting > to show up in the wild from other distributors of electronic media such > as ours so I figured I'd get a jump up). >
I'd suggested this be an option controllable in the manifest, which perhaps is overkill, though on many systems it's going to be a bit time-consuming to compute three different hashes on gigabyte-ish files. That could also be accomplished somewhat more obliquely if this were made a separate step in the finalizer, at least; any reason you didn't choose that design? Dave
