* Karen Tung (Karen.Tung at Sun.COM) wrote: > On 02/08/10 14:30, Glenn Lagasse wrote: > >* Karen Tung (Karen.Tung at Sun.COM) wrote: > >>On 02/08/10 11:46, Glenn Lagasse wrote: > >>>Hi All, > >>> > >>>I need a quick review for the following two stopper bugs. I want to > >>>integrate them into 133 so a quick turnaround would be appreciated. > >>>These are merely doc changes so no code to review (other than the > >>>packaging changes). > >>> > >>>http://defect.opensolaris.org/bz/show_bug.cgi?id=14371 > >>>http://defect.opensolaris.org/bz/show_bug.cgi?id=14304 > >>> > >>>Webrev: > >>> > >>>http://cr.opensolaris.org/~glagasse/slim_docs/ > >>> > >>>Thanks! > >>> > >>Hi Glenn, > >> > >>I believe you also need to update usr/src/cmd/distro_const/docs/Makefile to > >>add all the new html files there. > >> > >>Can you do a top down clobber build of the gate to make sure there's > >>no error from the Makefile changes you made? > >I don't know how I didn't see this in my testing. But I missed quite a > >bit. > > > >I've made some additional changes (makefile related) to put things where > >they need to be as well as added the new doc files to the appropriate > >Makefile. > > > >Could you have another look at let me know if it looks good to you. > > > >Thanks Karen. > > > >Glenn > Hi Glenn, > > Everything looks OK to me now. > I assume that you did a clobber top-down build and made sure > that everything is OK?
Yep, I did. I also re-verified that installing the built SUNWdistro-const places the man pages and the docs in the proper places with the proper content. Thanks Karen. -- Glenn
