Hi Glenn, On Thu, 11 Feb 2010, Glenn Lagasse wrote:
> Hi Sue (and team), > > * Susan Sohn (Susan.Sohn at Sun.COM) wrote: >> The incremental webrev for the text installer project has been posted at: >> http://cr.opensolaris.org/~kemitche/text_v3_incremental/ >> >> This webrev shows the diffs from the original code review with certain >> exceptions as described in the NOTE below. >> >> The full webrev to date is located at: >> http://cr.opensolaris.org/~kemitche/text_v3/ >> >> We would like to get feedback on this round of changes no later than COB >> Tuesday, 2/9, if at all possible. If you would like to review these changes >> but >> can't be done with your comments by then please contact me and we'll work >> something out. > > I reviewed the same file set as I had previously. Only a couple of > questions. > > usr/src/cmd/distro_const/text_install/text_mode_sparc.xml: > > Why are we including gcc-dev in the initial package list? > > usr/src/cmd/distro_const/text_install/text_mode_x86.xml: > > Why are we including gdb in the initial package list? And why isn't it > in the sparc package list (Does gdb not run on sparc)? > Why are we including gcc-dev in the initial package list? gcc was requested by marketing in the initial package list (as was gdb). That said, both of these packages along with a number of others will be removed as part of - 14071 text install package list needs to be trimmed down I'll be putting out a code review for that to the list real soon now. Thanks for the review! Alok
