Because of the way the live CD install does it's cpio of the live CD image it turns out that Dermot is indeed correct that this fix is not sufficient. Because the cpio copies the menu.lst off of the live CD we end up with the menu.lst from the CD and not the one from the microroot. Because of this we still need to remove the menu.lst from the installed BE (for example /a/boot/grub/menu.lst). We then need to copy the menu.lst file from the microroot into the installed BE.
I've reverted this so that we are still removing /boot/grub/menu.lst but then copying the correct version from the microroot into it's place. I've updated the webrev with the corrected fix. Thanks, -evan On 2/12/10 11:34 AM, Dermot McCluskey wrote: > Evan, > > This looks file, but it seems (from reading the bug) that > in previous releases, /boot/grub/menu.lst was overwritten > with a stub file that referred to the "correct" menu.lst > file in the root pool. > > Is that not a better fix? ie might it confuse a user if > /boot/grub/menu.lst contains valid entries, but isn't > being used? > > > - Dermot > > > > > On 02/12/10 18:16, Evan Layton wrote: >> I need to get a couple of reviews for this very simple fix. It needs to >> go into both branches and is a stopper bug. >> >> webrev: >> http://cr.opensolaris.org/~evanl/14475/ >> >> Defect: >> http://defect.opensolaris.org/bz/show_bug.cgi?id=14475 >> >> Tested by building images and installing to make sure that >> /boot/grub/menu.lst still existed after the install. >> >> Thanks! >> -evan >> _______________________________________________ >> caiman-discuss mailing list >> caiman-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
