On 02/17/10 02:19 PM, Glenn Lagasse wrote: > Hi Keith (et-al), > > * Keith Mitchell (Keith.Mitchell at Sun.COM) wrote: > >> Hi Glenn, >> >> I was initially confused as to why all messages were sent to stderr, >> but I think I understand it now. >> >> stderr messages get logged in both detail and simple logs, stdout >> get logged in just the detail log - is that correct? (Perhaps a >> comment calling that out would be good) >> > Your understanding is correct and I've added a comment to that effect. > I expect this stuff will change with the great logging rewrite. > > >> Line 404, what is throwing an AttributeError? That's an odd >> exception to need to catch. >> > the logging. calls can throw AttributeError if you specify an incorrect > attribute (for instance, specifying sys.foo instead of sys.stdout). >
Python was probably evaluating "sys.foo" prior to passing it to logging (i.e., it likely wasn't a 'logging' specific error you encountered). In any case, since you're not attempting to access attributes in a way that could throw AttributeError (sys.stderr and sys.stdout seem safe), I don't think there's any need to catch AttributeError here. > >> No other complaints from me (other than the line wrapping that's >> been mentioned multiple times - the indentation should align with >> the opening quotes from the prior line in each case) >> > I've fixed those as well. pylint is still happy. > > Please have a look again and let me know if I missed anything. > No other issues (I don't think webrev picks up the whitespace changes, so I'm assuming everything lines up appropriately at this point) - Keith > Thanks! > >
