William, See comment below.
On 02/18/10 12:03, William Schumann wrote: > Dermot, > > On 02/16/10 01:49 PM, Dermot McCluskey wrote: >> In section 3, "The Validator for slices and fdisk partitions will >> require access to methods from the disk object...". Is this just >> saying you need a get_parent_disk() method in the Partition and Slice >> classes in order to access the disk's attributes, or is it something >> more? > No, it's nothing more than that, really. It's just trying to say that > the slice (and fdisk partition) classes need info from the disk class. > Worded this more simply. >> >> Also, in section 3: can you say a little more about why you see the >> need for derived classes for Disk (EFI, PC BIOS) and Partition (EFI >> and SMI). > Current text from section 3: >> >> Derived classes for slices of differently-labeled disk (PC BIOS vs. >> UEFI/GPT) will be used to separate and modularize the programming, and >> to avoid code branching and other complexities in higher-level code. >> > What do you think is lacking in this explanation? I am not sure what > else to say about this but to give examples of how UEFI differs from PC > BIOS. This is more for my own information: I would have assumed the one class for Disks would suffice. If you already know that different sub-classes for PC BIOS vs UEFI/GPT Disks will be required, then you've probably looked into it and decided that they are sufficiently different to warrant this. Are the attributes and methods very different, or is it just more logical to use different classes for them? Thanks, - Dermot >> >> In section 5, "The routine om_validate_and_resize_partitions()..." >> There is no such routine (although it is referenced in some comments). >> I think you want om_validate_and_resize_disk_partitions(). > Indeed - corrected this. > > Thanks, > William
