Thanks Sue. I added a docstring for that function and updated the incremental webrev: http://cr.opensolaris.org/~kemitche/14372_v2/
- Keith On 02/24/10 01:47 PM, Susan Sohn wrote: > Keith, > > In addition to what Alok said, just a nit: > > scroll_window: > 48 redrawwin needs a comment (I'm surprised pylint didn't complain) > > Sue > > On 02/23/10 12:24, Keith Mitchell wrote: >> Pardon the churn - the webrev has been updated (in place) slightly >> again, to use the xpg4 version of awk, to address concerns from >> comment 6 of bug 14372 >> <http://defect.opensolaris.org/bz/show_bug.cgi?id=14372>. >> >> - Keith >> >> On 02/23/10 10:40 AM, Keith Mitchell wrote: >>> FYI - I've updated the fix for 14372 based on comment 4 of the bug: >>> http://defect.opensolaris.org/bz/show_bug.cgi?id=14372#c4 >>> In the process of testing now, but I don't anticipate any issues as >>> a result. >>> >>> The original webrev has been replaced with the one that contains the >>> updated code. >>> >>> - Keith >>> >>> On 02/23/10 09:24 AM, Keith Mitchell wrote: >>>> Hi all, >>>> >>>> I'd like to request a review for my changes in the text install >>>> gate for bugs 14206 and 14372. >>>> >>>> Webrev: >>>> http://cr.opensolaris.org/~kemitche/14206.14372/ >>>> >>>> Bugs: >>>> http://defect.opensolaris.org/bz/show_bug.cgi?id=14206 >>>> http://defect.opensolaris.org/bz/show_bug.cgi?id=14372 >>>> >>>> Summary: >>>> - Updated text-mode-menu.ksh to read /etc/passwd to spawn the >>>> "Shell" option based on the user's login-shell >>>> - Updated main_window.py to repaint the screen when ctrl-L is >>>> pressed; streamlined different places in the code so that all calls >>>> to "getch" flow through main_window.py (previously there was some >>>> scattering of code there) >>>> >>>> Testing done: >>>> For 14372: Copied the text-mode-menu.ksh changes to a system booted >>>> with the text installer image. Changed the SMF start/exec property >>>> to point at the modified menu, and restarted the service. Verified >>>> that the shell spawned matched what was defined as root's login shell. >>>> >>>> For 14206: Temporarily added code that distorts the screen at >>>> regular intervals; verified that ctrl-L would repaint the entire >>>> screen in all cases (while on a text only screen, while in an >>>> editable field, while selecting an item from a list, while a pop-up >>>> window was active, and during the installation itself). >>>> >>>> Additional note: >>>> I updated disk.c, partition.c, and slice.c to quiet some build >>>> warnings nightly was giving. There is no bug for those changes, but >>>> if there's concern about the changes here, I will file a bug and >>>> address the issue separately. >>>> >>>> Thanks, >>>> Keith >>>> _______________________________________________ >>>> caiman-discuss mailing list >>>> caiman-discuss at opensolaris.org >>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >> >> ------------------------------------------------------------------------ >> >> _______________________________________________ >> caiman-discuss mailing list >> caiman-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >
