Ethan,

What I noticed is that the configuration always was left justified
thus Listen always started in column 0.  I'll change the line to
be:

        sed -n -e '/^#/d' -e '/ListenBacklog/d' -e '/Listen/p'.

That would exclude "# Listen ", "ListenBacklog" and others but
include <tab>,' ' and ^Listen.

I'll also add some code to play around with the match in the C
code.

Thanks,

John



On 02/25/10 06:22 PM, Ethan Quach wrote:
> John,
>
> installadm_util.c - 531 - does this match if there's white
> space in front of Listen? Also, what if there's a tab after
> Listen instead of a space?
>
> installadm-common.sh - 280 - Same comments.
>
>
> thanks,
> -ethan
>
>
>
> On 02/25/10 16:01, John Fischer wrote:
>> All,
>>
>> Here is another webrev that I need reviewed:
>>
>> http://cr.opensolaris.org/~johnfisc/6047-http_port/
>>
>> This is for:
>>
>> http://defect.opensolaris.org/bz/show_bug.cgi?id=6047
>>
>> Essentially we used to hard code the port number to be
>> 5555. This code retrieves the port number from the
>> ai-httpd.conf file. The code defaults to 5555 if the
>> port number can not be retrieved.
>>
>> Thanks,
>>
>> John
>> _______________________________________________
>> caiman-discuss mailing list
>> caiman-discuss at opensolaris.org
>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
> _______________________________________________
> caiman-discuss mailing list
> caiman-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to