On that basis, I'm happy with the change :) Thanks,
Darren. On 03/ 2/10 11:43 AM, Matt Keenan wrote: > On 03/ 2/10 07:53 AM, Darren Kenny wrote: >> Matt, >> >> I'm a little confused here, the bug talks about the minutes being >> inconsistent, >> i.e. 12:4 vs 12:04. >> >> But the code you changed seems to suggest that it's hours that's >> inconsistent... >> >> Darren. >> >> On 03/ 1/10 06:13 PM, Matt Keenan wrote: >>> Hi, >>> >>> Code review request for top_60 bug : >>> 1094 - Inconsistent number representation in time/date setting >>> http://defect.opensolaris.org/bz/show_bug.cgi?id=1094 >>> >>> Webrev : >>> http://cr.opensolaris.org/~mattman/bug-1094/ >>> >>> >>> Most of code to cater for this was actually there already , just missing >>> case >>> for the Hour. > > Specific code to handle hours was missing, specific code to handle minutes, > days > and months is already in place. > > The real issue was that the sequence in which this code was being executed. > The > call to initialize the date/timezone window was being done before the actual > window and wigets were mapped, resulting in it being ignored. The solution is > to > move call to : > > datetimezone_set_current_date_and_time(); > > From the early app initialization location to be called just as the > datetimezone > window is being displayed. > > cheers > > Matt > > >>> >>> Problem was function to set the values for the spin buttons was being called >>> before the widgets were mapped, just needed to move the call to be invoked >>> after >>> main date/timezone window container widget has been displayed. >>> >>> Code to be commited to tip only. >>> >>> cheers >>> >>> Matt >>> _______________________________________________ >>> caiman-discuss mailing list >>> caiman-discuss at opensolaris.org >>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss > > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
