Hi Jack, All changes look good to me.
- Keith On 03/ 1/10 11:36 AM, Jack Schwartz wrote: > Hi Keith. > > Here is a differential webrev: > > http://cr.opensolaris.org/~schwartz/100228.1/webrev.1.2.diff/ > > Most files have small changes. A few have big ones: > > - auto_ddu_lib.c required changes to parsing logic, else it would have > mis-handled two packages coming from the same location. (This was the > bug Mary found early on.) The C-Python interface code is ~same as > before. > > - install_utils/ManifestServ.py required changes to allow calling it > the old way from DC and install_tools/ManifestServ, and to simplify > calling it from AI. This was in response to your and Karen's comments. > > A few other notes: > > - install_tools/ManifestServ.py and distro_const.py files are restored > to their original form, so they don't show up. > > - ai_manifest.xml was added as the appropriate place to contain the > lavish Driver Update comments which Dave asked me to remove from > default.xml. > > Thanks, > Jack > > P.S.: BTW, I just learned that webrev lets you point to an old webrev > to generate a differential: webrev -p <old_webrev> > This feature made this possible... > > > On 03/01/10 10:14, Keith Mitchell wrote: >> Hi Jack, >> >> Would it be possible to generate a differential webrev, perhaps? >> >> - Keith >> >> On 02/28/10 09:22 PM, Jack Schwartz wrote: >>> Hi everyone. >>> >>> Here is the updated webrev, after incorporating changes from Dave, >>> William, Keith and Karen. If there are any other issues please let >>> me know ASAP. >>> >>> http://cr.opensolaris.org/~schwartz/100228.1/webrev/ >>> >>> Original webrev is still at: >>> http://cr.opensolaris.org/~schwartz/100209.1/webrev/ >>> >>> Thanks, >>> Jack >
