Hi all, I need a reviewer for the following text installer bug: http://defect.opensolaris.org/bz/show_bug.cgi?id=14074 Deleted partitions not always deleted
Webrev: http://cr.opensolaris.org/~kemitche/14074/ Summary: Our interface into libti had us sending in a partition table only consisting of the desired partitions. If the desired partitions haven't changed in size or type, libti skips writing the fdisk table. The catch is, if partitions are deleted but not passed to libti, libti doesn't compare the deleted partition with the original to see a change. The fix is to pass all existing and new partitions into libti, so it has sufficient data for comparison, and will recognize the need to delete. Testing: - Verified that for a system with existing Solaris2 partition and other partitions, if the other partitions are set to "Unused" (i.e., deleted), and the Solaris2 partition is untouched, then the final partition table contains only the original Solaris2 partition. - Verified that standard install scenarios continue to work - Verified that the check in instantiate.c that skips partitions with 0 blocks is not needed by forcing the installer to create a linux native partition with 0 blocks. Note: I discovered an issue while testing where, if the original partition table consists of a Solaris2 partition, an extended partition, and a single logical partition, the logical partition is not deleted. However, I cannot delete the single logical partition using "fdisk -F <file> <disk>" either, so this is neither a text installer nor a libti issue. If there is more than one logical partition, the partitions delete as expected.
