* Keith Mitchell (Keith.Mitchell at Sun.COM) wrote: > Hi all, > > I'd like a code review for the following bug: > 15230 Text Installer push missed a file > http://defect.opensolaris.org/bz/show_bug.cgi?id=15230 > > Webrev: > http://cr.opensolaris.org/~kemitche/15230/ > > This bug needs to be fixed, as slim_source is currently not > building. The files missed the original push as a result of bug > 15229, which I'll see about addressing later. > > Note that the file content has already been reviewed as part of text > installer code reviews. > > Verification done: > After committing said changes, I cloned the workspace and built from > the clean clone to ensure that slim_source does indeed build after > those two files were added. Therefore, these really are the only two > missing files.
Looks fine to me. -- Glenn
