Hey Sanjay, [path to updated CR lacks your ~userid btw]
Couple of questions: 1231 - Is this going to work with hierarchical package names? e.g. pkg://opensolaris.org/system/library at 0.5.11,5.11-0.135:20100312T101036Z 1217-1235 - It seems to me that with this code, the last instance of a package (for the edge and perhaps error case that a package might be specified more than once for whatever reason) would just take the last instance of the package and throw way earlier ones? thanks, -ethan On 03/24/10 11:37, sanjay nadkarni (Laptop) wrote: > The code review with the change is now available at: > http://cr.opensolaris.org/bugfix_15132 > > -Sanjay > > > On 03/24/10 09:52 AM, sanjay nadkarni wrote: >> On 03/24/10 07:47 AM, Dave Miner wrote: >>> >>>>> 1249-52: I'd think you could turn this into simply >>>>> >>>>> pkgs = " ".join(order.values()) >>>>> >>>> That will not work, since order is a list of keys not a dictionary. >>>> >>> >>> Yeah, missed that. Fine then. >>> >>> Dave >> I have a fix that addresses the primary concern that you expressed >> i.e. will keys work if the pkg is expressed as a complete FMRI and I >> will be posting the webrev soon. >> >> The supported formats can be any of the following. I am using entire >> as an example here. >> entire >> entire at [email protected],5.11-0.134 >> entire at 0.5.11,5.11-0.134:20100302T023003Z >> pkg://pkg.opensolaris.org/entire at 0.5.11,5.11-0.134 >> pkg://pkg.opensolaris.org/entire at 0.5.11,5.11-0.134:20100302T023003Z >> >> -Sanjay >> >> >> >> -Sanjay >> >> _______________________________________________ >> caiman-discuss mailing list >> caiman-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss > > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
