Clay,

Just a nit.  Any reason why you chose to redirect the call at
309, instead of at 189 ?

The changes look fine.


thanks,
-ethan


On 04/01/10 15:05, [email protected] wrote:
Hi Ethan,
Per our discussion of the duplicated output issue when using prompt but not install boot args, I've tested a fix per our hunch of exec in do_get_manifest and tested using the testing method you suggested with lofs. All worked correctly (i.e. no duplicated output). As such a new webrev is available at:

Webrev:
http://cr.opensolaris.org/~clayb/15323/webrev1/

Differential Webrev:
http://cr.opensolaris.org/~clayb/15323/webrev1.diff/

                            Thank you,
                            Clay

On Thu, 1 Apr 2010, [email protected] wrote:

Hi Ethan,
I've reverted back to the Sun copyright since this is going to be targeting 134a and 136.
                            Thank you,
                            Clay

On Wed, 31 Mar 2010, [email protected] wrote:

Hi Ethan,
This is to confirm this code looks okay. This is the same code you privately okayed but now with the Oracle copyright. I've tested that the svcadm enable auto-install works or that an install proceeds as expected for the following cases; further this documents the various possible boot combinations.

Webrev:
http://cr.opensolaris.org/~clayb/15323/

X86:
    Network boot:
        Standard:
        ---------
        Boot default GRUB entry -- comes up and displays service
                       discovery messages then prints
                       standard message to use svcadm;
                       ran svcadm enable auto-install
                       to install
        Boot second (automated) GRUB entry -- simply installed
        Also tried modifying the GRUB entries (to have
        prompt=True):
        ----------------------------------------------
        Default GRUB entry -- came up and prompted for manifest
                      then required svcadm enable
                      auto-install to install
        Second (automated) entry -- came up and prompted for
                      manifest then proceeded to install
                      it (opposed to using mDNS, etc. to
                      find manifest)

    Bootable AI Boot:
        Standard CD boot:
        -----------------
        Custom (menu option 1) -- prompts for manifest as expected
                      and then installs
        Go!    (menu option 2) -- does not prompt for manifest and
                      installs
        Also for each respective entry I have manually edited the
            install=True to install=False:
        ---------------------------------------------------------
        Custom: -- prompts for manifest then requires svcadm
               enable auto-install to install
        Go! -- prompts for manifest then requires svcadm enable
               auto-install to install

SPARC:
    Network boot/LiveCD boot:
        boot [net:dhcp|cdrom] -- comes up and displays service
                     discovery messages then prints
                     standard message to use svcadm;
                     ran svcadm enable auto-install to
                     install
        boot [net:dhcp|cdrom] - install -- comes up and displays
                           service discovery
                           messages then installs
        boot [net:dhcp|cdrom] - prompt -- comes up and prompts for
                          manifest and then prints
                          standard message to use
                          svcadm; ran svcadm
                          enable auto-install to
                          install
        boot [net:dhcp|cdrom] - install prompt -- comes up and
                              prompts for
                              manifest and
                              then installs
                              using custom
                              manifest
                              provided


        (One issue with the manual -- prompt -- but don't install
         manifest discovery path, is the message to enable
         auto-install is duplicated when its printed. As this is
         unsupported, I didn't investigate a fix and was unable to
         determine why too.)


                            Thank you,
                            Clay


_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to