On Wed, 2010-04-07 at 11:25 +0200, Jan Damborsky wrote:
> Hi Alex,
>
> since it seems like this bug is not a stopper for incoming release
> (at least it is not marked as blocker for 8314), I believe only one
> reviewer is sufficient.
> That said, I have looked at the webrev and I have only one nit :-)
> I tried the ed(1) command which is used to set TZ in /etc/default/init
> and it seems to display matching lines to stdout:
>
> $ printf "/^TZ=.*/\ns/^TZ=.*/TZ=GMT/\nw" | /usr/bin/ed -s /tmp/init
> TZ=Europe/Prague
> $
>
> Should we redirect stdout to /dev/null, so that this output does not
> appear in log files ? Something like
>
> $ printf "/^TZ=.*/\ns/^TZ=.*/TZ=GMT/\nw" | $ED -s
> $BA_BUILD/etc/default/init > /dev/null
>
>
> Thank you,
> Jan
>
>
>
> On 04/ 7/10 09:04 AM, Alexander Eremin wrote:
> > On Tue, 2010-04-06 at 15:07 -0400, Dave Miner wrote:
> >> On 04/ 1/10 03:54 PM, Alexander Eremin wrote:
> >>> Please review the two-lines fix at
> >>> http://cr.opensolaris.org/~alhazred/745
> >>> for bug
> >>> 745 System timezone default set to US/Pacific - should be GMT
> >>>
> >>
> >> Change looks OK, have you verified that clock ends up displaying
> >> correctly in the installer and set correctly on the installed system?
> >>
> >> Dave
> > Thanks for reviewing, Dave,
> > yes, after usual boot I have incorrect time, with fix - time is correct
> > in system and installer (and after installation I've got right time and
> > TZ)
> >
> > Need one more review,please.
> > Alex
> > _______________________________________________
> > caiman-discuss mailing list
> > [email protected]
> > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
You're right, this should not be in the log )
Webrev's updated, thank you very much.
Alex
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
