Hi Alok,
First, in regards to the copyrights:
For the purposes of consistency with Sue's fix for 15511, and because
the text installer source files were originally available in an
externally visible gate in 2009 (even though that gate was not
slim_source, it was still a source code repository in use by OpenSolaris
developers), please use the "2009, 2010" format for the files modified
that were introduced as part of the text installer project.
Additionally, as media-fs-root can be tracked in slim_source back to
live-fs-root, and that file has an original copyright date of 2008, so
the copyright for that file should be "2008, 2010". (Unless that file
has been around longer and that data can be readily tracked down, in
which case use the earliest appropriate date).
The code itself looks fine, just a few nits:
text_mode_x86.xml:
For consistency with text_mode_sparc.xml, should the default
distribution name end in _x86? (i.e., "OpenSolaris_Text_x86")
users.py:
Check alignment on lines 148, 170, 211.
Thanks,
Keith
On 04/ 7/10 12:35 PM, Alok Aggarwal wrote:
Could I please get a review of the fixes for the
following defects -
15456 text install images with the default manifest don't build after
push for 13276
15461 media-fs-root should request console access better
15463 text-mode-menu needs better console redirection handling
15529 Minor issues with fix for 15167
Webrev -
http://cr.opensolaris.org/~aalok/15456-15461-15463-15529/
Thanks,
Alok
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
