On Tue, 29 Jun 2010, John Levon wrote:
On Tue, Jun 29, 2010 at 01:58:27PM -0700, Keith Mitchell wrote:
The webrev has been updated in place with my proposed fix:
http://cr.opensolaris.org/~kemitche/16400/
The fix looks OK, but now I think about it, it's relying on some unusual
code in lofiadm's wait_until_dev_complete():
311 /* First use di_devlink_init() */
312 if (hdl = di_devlink_init("lofi", DI_MAKE_LINK)) {
313 (void) di_devlink_fini(&hdl);
314 goto out;
315 }
I've only just noticed that lofiadm tries to create links itself, which
is pretty weird, and now you'll be relying on it.
lofiadm doesn't return until the link appears in the
/dev namespace so I think we're okay here.
I guess it's not worth it since it's a different gate, but this piece of
lofiadm code could really do with a comment as well stating why the code
is there (now).
Longer term it might be better for lofiadm to call out to devfsadm -i
lofi on some trigger (an env var??)
Isn't the better way to actually call ddi_create_minor_node
in the kernel and have the link generator handle the minor
node creation? I may be way off since it's been a while since
I looked at this stuff.
Alok
_______________________________________________
caiman-discuss mailing list
caiman-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
