Hi Dave.
On 09/15/10 08:45 AM, Dave Miner wrote:
Jack, Karen, Clay,
Thanks for review, a revised webrev is posted at same URL, below.
Regarding two of Clay's comments:
* Just to confirm, I believe what you're doing is equivalent to
the following too?
beadm list -Hd|grep ';R;'|cut -d ';' -f 2
Not quite, in that the nawk expression finds R anywhere in field 3, so
that additional state flags, such as in an entry like the below, don't
throw it off.
b-147;rpool/ROOT/b-147;NR;/;103153307136;static;1283816283
There is an implicit assumption in this method that there aren't
multiple pools with potentially active boot environments present in
the AI environment, which is true today but possibly not in the
future. It would be better to move this functionality into the AI
application so that it can directly handle the reboot to its known BE,
but we'll defer that to the post-conversion application, where I hope
we'll just fold the functionality in this script into the app.
Thanks for making the code changes.
I noticed that implicit assumption too. I think it would be useful to
add a comment about that assumption in svc/auto-installer. Do you
agree? (After all, you felt you had to explain it here...)
Thanks,
Jack
* You might want to comment that reboot -f should be fine and
will just warn about no dataset (or whatever the behavior is) if
for whatever reason $dset is null?
While reboot would do something useful, dset can't be null. If it is,
then there's a bug in beadm or AI. Thus the comment is unnecessary.
Dave
On 09/14/10 02:03 PM, Dave Miner wrote:
I need two reviewers for some small fixes:
6982854 support nfs file based repos with auto-install
11087 auto-install should at least try to do a fast-reboot after install
13196 should turn off fastreboot_onpanic in microroot environment
8396 var/installadm/services should be removed from install/installadm
Webrev is at
http://cr.opensolaris.org/~dminer/slim_6982854/
Thanks,
Dave
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
