Hi Ethan,

That's a perfectly fine approach. I just didn't get to ksh93'ing net-fs-root yet. I've gone with that approach though, and implemented it as:

if [[ "$MEDIA" == ~(E)'\$serverIP' ]]; then

                                                        Thank you,
                                                        Clay

On Tue, 23 Nov 2010, Ethan Quach wrote:

Clay,

Just one comment in net-fs-root. Since the value grepped isn't actually needed, why not do what manifest-locator does at line 116 instead?

  if [[ "$MEDIA" == ~(E)'^\$serverIP:' ]] ; then


-ethan


On 11/22/10 14:39, [email protected] wrote:
Hi all,
Would someone have a moment for a 9 line code review? This addresses three multihomed introduced bugs: 7000597 When a DHCP BootFile value's set to a contradictory value AI reports one should set it to $boot_file 7000701 installadm fails to properly find the default router for some networks
7000807 net-fs-root incorrectly tests for a null string

Webrev:
http://cr.opensolaris.org/~clayb/multihomed_bug_fixes/

                    Thank you,
                    Clay
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to