Jan,
Thanks for adding the comments. Looks ok to me.
-ethan
On 12/08/10 23:26, Jan Damborsky wrote:
Hi Ethan,
thank you very much for review.
Please see my response in line.
Jan
On 12/ 9/10 03:30 AM, Ethan Quach wrote:
Jan,
These changes seem to assume that the list of shared filesystems to
be created are already ordered hierarchically, and will only contain
one stream of hierarchy. In looking at the existing code, it also
assumes the former, but not necessarily the latter.
Yep. You are right.
However, since we are currently hardcoding the list of shared
datasets to create anyway, I suppose this isn't really a regression,
but could you please add block comments to make these assumptions
clear just in case this code is used as a base for newer/later
implementations of TI or dataset creation code.
I have added appropriate comments to all touched files as well as
addressed your comments below.
The diff and full webrevs can be looked at:
http://cr.opensolaris.org/~dambi/bug-7004852-diff/
http://cr.opensolaris.org/~dambi/bug-7004852-cr/
These are really all just nits:
ti_install.py
--------------
505 - I don't think /opt should be in this comment anymore.
514,518 - ancestor -> the oldest ancestor; child -> children
perform_slim_install.c
----------------------------
2235 - Remove /opt
2262, 2278 - ancestor -> the oldest ancestor; Child -> Children
ti_bem.c
-----------
358 - child -> children
372 - ancestor -> the oldest ancestor; Child -> Children
382 - Typo - acestor -> ancestor
thanks,
-ethan
On 12/08/10 10:46, Jan Damborsky wrote:
Hi Ethan,
could I please ask you to review fix for following CR ?
7004852 After installing use the x86 Auto install, the newly
installed machine fails to boot
Webrev is located at:
http://cr.opensolaris.org/~dambi/bug-7004852/
Thank you,
Jan
testing done:
* built x86 AI, text, GUI install images based on build 154
containing the bug fix
* x86 AI, text, GUI successful installation carried out
* It was verified on installed system that children of
<root_pool>/export dataset
have their mountpoint property inherited from <root_pool>/export
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
