Hi Ethan,
boot_archive_archive.py:
160, 167: Nit / peeve: In general, defer string formatting operations to
the logger by passing the format parameters as args to the logger call:
self.logger.debug("BA size before padding: %d", size)
test_boot_archive_archive.py:
85: Per our discussion today, I think this should actually be:
min_expected_size = 125 * 1024 # 125 MB
i.e., don't rely on dir_size here.
- Keith
On 04/ 1/11 03:30 PM, Ethan Quach wrote:
Can a get a review for the following bugfix:
http://cr.opensolaris.org/~equach/webrev.6974245/
All image types in both architectures were built. All x86 images have
their writable space up'ed from ~10MB to ~25MB, which addresses the
bug. And all Sparc images have their writable space at about ~50MB.
(I believe the reason Sparc images end up with a lot more writable
space is because part the sparc content ends up getting compressed,
and so ends up using less space than the initially measured amount,
thereby leaving more writable space leftover. I think this is OK, I'd
rather not use different values for the two architectures.)
thanks,
-ethan
_______________________________________________
caiman-discuss mailing list
caiman-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
caiman-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
