Mary,
Looks good. Only a nit to change the text from "Partition not in used" to
"Partition not in use". No need to re-review it if you make that change.
Thanks,
John
On 05/23/11 05:59 PM, Mary Ding wrote:
Hi:
Can I get a simple code review request for 7047621 ???
http://monaco.us.oracle.com/detail.jsf?cr=7047621
The diff is a simple one-liner to fix a typo error:
diff -r 47266a70ba5f -r b5b7daf22e33
usr/src/cmd/text-install/ti_target_utils.py
--- a/usr/src/cmd/text-install/ti_target_utils.py Mon May 23
10:49:53 2011 -0600
+++ b/usr/src/cmd/text-install/ti_target_utils.py Mon May 23
17:58:00 2011 -0700
@@ -1037,7 +1037,7 @@
elif self.ui_type == UI_TYPE_EMPTY_SPACE:
obj = self.empty_space_obj
else:
- raise RuntimeErorr("Partition not in used")
+ raise RuntimeError("Partition not in used")
size_in_sector = (obj.size).get(Size.sector_units)
return (obj.start_sector + size_in_sector)
I had run the slim install unit test and there is no additional failure.
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
