Looks good drew.
cheers
Matt
On 05/24/11 21:57, Drew Fisher wrote:
Good afternoon!
Could I get a code review for:
7047952 <http://monaco.us.oracle.com/detail.jsf?cr=7047952> update the
BENodeList class to account for a new member variable
It's a simple one-line fix:
diff -r ff4a15105908 -r 71e577959dd1
usr/src/lib/install_target/libbe/cstruct.py
--- a/usr/src/lib/install_target/libbe/cstruct.py Tue May 24
08:06:46 2011 -0600
+++ b/usr/src/lib/install_target/libbe/cstruct.py Tue May 24
15:03:02 2011 -0600
@@ -78,6 +78,7 @@
("be_mounted", C.c_int), # is BE currently mounted
("be_active_on_boot", C.c_int), # is this BE active on boot
("be_active", C.c_int), # is this BE active currently
+ ("be_active_unbootable", C.c_int), # is this BE potentially bootable
("be_space_used", C.c_uint64),
("be_node_name", C.c_char_p),
("be_rpool", C.c_char_p),
This brings the ctypes definition of BENodeList in line with of
libbe.h's be_node_list structure and has a lovely side effect of
preventing ctypes be_list() from core dumping when you list all the
BE's on a system! Two for one!
Thanks!
-Drew
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
