On 05/23/11 09:09, Evan Layton wrote:
Hi Ethan,
You had mentioned that you wanted someone to concentrate on the
Makefiles and package manifests so I concentrated on those. These all
look really good and the only thing I could see was the copyright date
for distro_const/Makefile is still 2010 but since you're simply
removing one line I'm not sure this is something to worry about.
I'll update it. Thanks for the review.
-ethan
-evan
On 5/20/11 4:38 PM, Ethan Quach wrote:
Drew, Matt, Evan, William,
I have an updated the webrev incorporating all of your comments from
the initial
review. (This is sync'ed with the AI->CUD gate as of cid 2460) In
addition, this
update also includes changes to the AI server side to enable
processing value
criteria as a list of values. The files related to that change are:
usr/src/cmd/ai-webserver/AI_database.py
usr/src/cmd/ai-webserver/cgi_get_manifest.py
usr/src/cmd/ai-webserver/common_profile.py
usr/src/cmd/ai-webserver/create_profile.py
usr/src/cmd/ai-webserver/criteria_schema.rng
usr/src/cmd/ai-webserver/publish_manifest.py
usr/src/cmd/ai-webserver/set_criteria.py
usr/src/cmd/ai-webserver/verifyXML.py
usr/src/man/installadm.1m.txt
*
*(Thanks William for offering to take a look at those.)
Full updated webrev:
--------------------------
http://cr.opensolaris.org/~equach/webrev.16257-2
Incremental webrev:
--------------------------
http://cr.opensolaris.org/~equach/webrev.16257-2-diff
Original webrev:
--------------------
http://cr.opensolaris.org/~equach/webrev.16257
thanks,
-ethan
On 05/04/11 19:38, Ethan Quach wrote:
All,
I would like to request a review of the changes to support Zones in
AI. Please
be aware that this project gate is a child of the AI/CUD gate.
BugID:
--------
https://defect.opensolaris.org/bz/show_bug.cgi?id=16257
Webrev:
---------
http://cr.opensolaris.org/~equach/webrev.16257/
thanks,
-ethan
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
