Hi Mary,
In general looks good... :)
One comment though:
- ManifestServ.py around lines 309-312:
except TreeAccError:
print >> sys.stderr, "Error re-instantiating manifest \
tree:"
should probably be more like:
except TreeAccError:
print >> sys.stderr, "Error re-instantiating manifest" \
" tree:"
the first version will result in a lot of spaces in the output I believe.
Thanks,
Darren.
On 31/05/2011 04:39, Mary Ding wrote:
> Hi:
>
> I will like to request code review for the following bug fix.
>
> 7042081
>
> usr/src/lib/install_utils is not pep8 clean
>
>
> http://monaco.us.oracle.com/detail.jsf?cr=7042081
>
> The webrev is here:
>
> http://cr.opensolaris.org/~md5645/7042081/
>
> Packages had been compiled and install unit tests were run and there
> were no additional failure.
>
>
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
