Hi, Reminder:
John and I will be doing a code walk-through for those interested, in approx 1 hour (9am PT). We will be using Darren's concall number: US: 866-682-4770 408-774-4073 Ireland: 1800 932 479 Czech Rep.: 800 701 080 Other locations: http://www.intercall.com/oracle/access_numbers.htm Conference code: 6209463 Security pin: 0000 - Dermot On 06/01/11 18:12, Dermot McCluskey wrote:
Hi, I'd like to request a code review for the GUI Install -> CUD project. I need to set a timeout of Friday June 10th for this first round of comments. Please let me know if you intend to review, and also which of the sections listed below you will be looking at. The webrev is here: http://cr.opensolaris.org/~dermot/webrev-cud-gui-round-1/ The latest iso and usb images for the project are here: file:///net/indiana-build.us.oracle.com/var/lib/hudson/jobs/dc/cud_gui/media Below is my suggested grouping of the sources. If reviewers think a code walk-through would be helpful, then let me know. I could do this at, eg, 9am PT on Friday, 3rd or Monday, 6th or some other time if that doesn't suit. Thanks, - Dermot 1. Makefiles and manifest ================== usr/src/Makefile.master usr/src/cmd/Makefile usr/src/cmd/Makefile.targ usr/src/cmd/gui-aux/Makefile usr/src/cmd/gui-install/Makefile usr/src/cmd/gui-install/src/Makefile usr/src/cmd/gui-install/pixmaps/Makefile usr/src/cmd/gui-install/xml/Makefile usr/src/pkg/manifests/system-install-gui-install.mf 2. Glade UI Definition file ================== (These files are basically the old *.glade files which define the Gtk+ widgets and layout of each screen. They have been run through the gtk-builder-convert utility to convert them to the newer Gtk+Builder format, plus some minor tidying up.) usr/src/cmd/gui-install/xml/confirmation.xml usr/src/cmd/gui-install/xml/date-time-zone.xml usr/src/cmd/gui-install/xml/failure.xml usr/src/cmd/gui-install/xml/gui-install.xml usr/src/cmd/gui-install/xml/installation.xml usr/src/cmd/gui-install/xml/installationdisk.xml usr/src/cmd/gui-install/xml/users.xml 3. App startup and checkpoint setup; handle screens; misc. =========================================== usr/src/cmd/gui-install/src/gui-install.py usr/src/cmd/gui-install/src/__init__.py usr/src/cmd/gui-install/src/base_screen.py usr/src/cmd/gui-install/src/screen_manager.py usr/src/cmd/gui-install/src/gui_install_common.py usr/src/cmd/gui-install/src/help_dialog.py usr/src/cmd/gui-install/src/install_profile.py 4. Welcome Screen and Confirmation Screen ============= usr/src/cmd/gui-install/src/welcome_screen.py usr/src/cmd/gui-install/src/confirm_screen.py 5. Disk Screen ========== usr/src/cmd/gui-install/src/disk_screen.py usr/src/cmd/gui-install/src/fdisk_panel.py usr/src/cmd/gui-install/src/target_utils.py usr/src/lib/install_target/controller.py 6. Timezone screen ============= usr/src/cmd/gui-install/src/timezone_screen.py usr/src/cmd/gui-install/src/timezone.py usr/src/cmd/gui-install/src/map.py usr/src/cmd/gui-install/src/libzoneinfo_ctypes.py 7. User Screen ========== usr/src/cmd/gui-install/src/user_screen.py usr/src/cmd/gui-install/src/user_support.py 8. Progress Screen / Perform Installation =========================== usr/src/cmd/gui-install/src/progress_screen.py usr/src/cmd/gui-install/src/failure_screen.py usr/src/cmd/gui-install/src/finish_screen.py usr/src/cmd/gui-install/src/textview_dialog.py usr/src/cmd/gui-aux/imageurl.txt usr/src/cmd/system-config/profile/user_info.py _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
