Good afternoon!
Could I please get a code review for the following CRs:
7051114 <http://monaco.us.oracle.com/detail.jsf?cr=7051114> cannot do TI
install and got ValueError: Desired target doesn't pass final validation
7052336 <http://monaco.us.oracle.com/detail.jsf?cr=7052336> Add some
convenience methods to Disk class
http://cr.opensolaris.org/~drewfish/cr_7051114
For 7051114, we were checking against the wrong partition type. FAT16
has an upper bound of 4GB, not FAT32. *insert forehead slap here*
For 7052336, this is almost a straight pick-up of Dermot's
install_utils.py code from his gui-install webrev here:
http://cr.opensolaris.org/~dermot/webrev-cud-gui-round-1/usr/src/cmd/gui-install/src/target_utils.py.html
I added a comprehensive unittest for the new functionality to cover all
the new methods. Some of the name were slightly changed to better fit
into the Disk class.
Thanks!
-Drew
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
