Jan,
Consider this review as done by Drew and me. We both give it LGTM.
-Sanjay
On 06/ 6/11 01:15 PM, Jan Damborsky wrote:
Hi,
I would appreciate code review for following bug fixes:
7043012 Install technologies should benefit from PSARC/2011/057 for
purposes of timezone configuration
7042589 Install has to stop consuming libadmutil,libadmldb - they are
to be EOLed by PSARC/2011/128
7050709 Got hostname of "unknown" instead of "solaris" if I use the
static network sample to do install
webrev:
http://cr.opensolaris.org/~dambi/cr-7043012/
Please provide any comments before 6/9 COB Thursday, so that these
changes
could land in 168 build.
Thank you in advance,
Jan
Background:
With PSARC/2011/057 integrated into 166, post-install configuration of
timezone via setting of TZ variable in /etc/default/init should be
replaced
with configuring timezone/localtime smf property of system/timezone
smf service.
As part of that change, interactive installers which provide mechanism
for
adjusting date/time as part of the installation now keep time in UTC
format
in RTC on x86 systems. This consolidates x86 and Sparc platforms, since
Sparc already keeps time in RTC in UTC format.
Fix for 7043012 accommodates all install technologies to use that
new mechanism. As a result of that, it is possible to remove dependency
on legacy sysid libraries (fix for 7042589). That's welcome side effect
of timezone changes as those libraries will be EOLed by PSARC/2011/128
and will not be available in S11FCS.
Since static_network.xml was touched as well, I also fixed 7050709 while
being in that code.
Testing done:
* Built AI,TI,GUI images with modified Distro Constructor.
* Done AI,TI,GUI installation - it was verified that timezone was
correctly
configured on installed system.
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
