Hi Drew,
I have a nit, but otherwise it's looking good:
- discovery.py
- Line 256:
I know that python returns None if nothing is explicitly returned, but for
readability would it not be better to return None at the end of
discover_disk()? At least then it's obvious that it's intentional.
Thanks,
Darren.
On 22/06/2011 22:47, Drew Fisher wrote:
> Good afternoon!
>
> Could I please get a code review for the following bug:
>
> 7052696 <http://monaco.us.oracle.com/detail.jsf?cr=7052696> TI install fails
> with target discovery in snv_167 if there is floppy drive
>
> http://cr.opensolaris.org/~drewfish/cr_7052696/
>
> I tested the fix by actually finding a USB floppy drive and making sure that
> TD
> actually ignores it correctly. We're also throwing away any "drives"
> discovered
> by libdiskmgt that do not have a media attribute. The media attribute is
> where
> the size is set. Without the size, a large number of shadow_list tests fails
> outright causing icky traceback messages.
>
> Thanks!
>
> -Drew
>
>
>
> _______________________________________________
> caiman-discuss mailing list
> [email protected]
> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
