Looks good.
Harold
On 06/27/11 02:08 PM, Drew Fisher wrote:
Good afternoon!
Could I please get a code review for the following CRs:
7051027 <http://monaco.us.oracle.com/detail.jsf?cr=7051027> Installer
not enabling disk write cache when entire disk selected
7060008 <http://monaco.us.oracle.com/detail.jsf?cr=7060008> offline
disks cause a traceback error in discovery.py
https://cr.opensolaris.org/action/browse/caiman/drewfish/7051027/webrev/
for 7051027, I constructed an AI ISO to test my changes. I wrote a
quick toggle script that allowed me to set and disable the write-cache
on the root disk of system I was abusing. I ran AI's target
instantiation and confirmed that the write-cache is enabled if it
starts out disabled (and stays enabled if it started that way).
For 7060008, that same system has an offline disk which will now be
caught correctly, logged, and skipped gracefully. 2fer1!
-Drew
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
