Looks fine to me. -evan
Sent from my iPhone On Jun 29, 2011, at 1:31 PM, Harold Shaw <[email protected]> wrote: > This is a code review for: > > 7060803 tftp/udp6 service needs to be restarted after changing net boot > location in installadm-convert > > Once again since opensolaris.org is down here are the diffs. It is just a > call to svcadm refresh for tftp/udp6:default. > >> @@ -609,6 +609,18 @@ >> 'tftp/udp6 service to "%s"\n' % >> (os.path.basename(sys.argv[0]), val))) >> >> + cmd = ['/usr/sbin/svcadm', 'refresh', 'tftp/udp6:default'] >> + >> + try: >> + Popen.check_call(cmd, stdout=Popen.STORE, >> + stderr=Popen.STORE, logger='', >> + stderr_loglevel=logging.DEBUG) >> + except CalledProcessError: >> + sys.stderr.write(_('%s: warning: Unable to refresh the service: ' >> + 'tftp/udp6:default\nThis needs to be done before >> ' >> + 'attempting to do client installs\n' % >> + os.path.basename(sys.argv[0]))) >> + >> >> def del_prop_group(ai_service, dry_run): >> """ > > _______________________________________________ > caiman-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
