On 07/07/11 04:01, William Schumann wrote:
https://cr.opensolaris.org/action/browse/caiman/wmsch/7061147/webrev/
Exceeding the number of lines defined for the window caused the
strange exception.
The solution was to make entire welcome screen scrollable.
A slight inconvenience: the number of lines has to be pre-calculated
for the number of scrollable lines to be set in the WindowArea, which
means that everything has to be pre-formatted (despite the existence
of an independent setter method for scrollable_lines).
Thank you,
William
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
Hi William,
I have a few comments and questions.
- General question: I know making the whole window scrollable will fix
the problem, but I think
it will make things look a little odd. Can we perhaps re-word some of
the stuff on the screen
to make them shorter? Or layout some of the stuff a little
differently? For example,
instead of putting -network, -system hostname, - time zone...etc.. in
it's own line
for each item, maybe have 2 columns per item?
- Question, line 66: why is choose 2 for INDENT? Can you add a comment
to explain?
- lines 96-102: My understanding of what this code does is that the
WelcomeScreen.BULLET
string needs to be pre-pended to each of the BULLET_ITEMS, and then, we
run the
whole string through convert_paragraph() to get it formatted. Instead
of doing it the
way you have in the code right now, can you first prepend BULLET and
then, call convert_paragraph()
instead of doing it after you call convert_paragraph()? That seems to
be more efficient
than appending the bullet_items character-by-character.
Thanks,
--Karen
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
