Karen,
Please find my responses inline (where no response, your suggestion was
incorporated):
differences in
https://cr.opensolaris.org/action/browse/caiman/wmsch/7054440-diff/webrevdiff/
pyunit test changes found here were accidentally omitted from original webrev.
On 07/ 8/11 10:26 PM, Karen Tung wrote:
Hi William,
Here are my comments.
usr/src/cmd/system-config/__init__.py:
- Question: in terms of the sequence of screens that will appear,
looking at the code, it appears that first, I will be asked whether
I want to configure DNS, and regardless I say yes or no, the screen
to choose "other name services" will come up. For me, that doesn't
feel very natural. I would think that when I answer the question
that I want to configure DNS, the next screens will be screens that
does all the DNS configurations, and when I am done with configuring DNS,
then, the "other name service" screen will come up to see whether I want to
configure those.
This is because it would make the screen order for domain irregular. See below:
Screen order for DNS+Alternate:
-DNS yes or no
-Domain <<<<<<<
-DNS server
-DNS search
-Alternate NS yes or no <<<<<
...
Screen order if no DNS + Alternate:
-DNS Yes or no
-Alternate NS yes or no <<<<
-Domain <<<<<
...
So, in the first case, domain precedes the alternate name server selector, and in the second, domain follows the alternate name
server selector. If the user goes back and reverses the DNS selection, the screen order changes. Also, the screen list is
presently static in that it doesn't change after it is set, and the side effects of making it dynamic are unexplored. Also, the
problem might be averted by prompting for the domain last, for example, but several inputs are defaulted depending on domain.
usr/src/cmd/system-config/nameservice.py:
- line 131: since this is the screen to choose configure DNS or not,
I think it is not very accurate to call it "Name Service".
- lines 181-185: since the NSAltChooser always comes after the configure DNS or not selection screen, I think it will be very
useful to customize this message based on whether the user selected to use DNS or not.
The message was composed to be useful in either instance. In what ways might
it be customized?
- line 676: should it be "Server's hostname or IP address"?
- line 762: would it be more accurate to call this function
validate_host_or_ip()?
- line 763-764: The comment here doesn't reflect what the function is doing.
- line 776-779: why not just call validate_ip()?
Because validate_ip offers no additional benefit and an unnecessary dependency
would be created.
- line 780: need to "return True" here?
- lines 845-849: commented out code?
usr/src/cmd/system-config/profile/user_info.py:
- Question: are the changes in this file meant to be part of this fix?
It doesn't seem like it.
Changes here were to satisfy PEP8 requirements not done in the prior edit of
the file (source spacing only).
Thank you,
William
Thanks,
--Karen
On 07/ 7/11 04:05 AM, William Schumann wrote:
https://cr.opensolaris.org/action/browse/caiman/wmsch/7054440/webrev/
If DNS is selected, the IP address entered for an LDAP or NIS server can be a fully-qualified host name. Otherwise, the user is
required to enter a numeric IP address.
Profile property type host had to be added to profile/__init__.py for
fully-qualified host names to appear instead of IP addresses.
Another subclass of NameService is created for the DNS screen.
Some changes effect an option '-g naming_services', which prompts and generates
a profile only for name services, for testing only.
DNS screen:
------------------------------------------------------------
DNS Name Service
Indicate whether the DNS name service will be used by this system.
Configure DNS
Do not configure DNS
------------------------------------------------------------
LDAP or NIS or None screen:
------------------------------------------------------------
Alternate Name Service
Select one name service from the list below that will be used by this
system. Select None if the desired name service is not listed. The
selected name service may be used in conjunction with DNS.
None
LDAP
NIS
------------------------------------------------------------
Tested SCI tool and text installer ISO.
Pyunit Tests updated.
Thanks for your attention,
William
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
