William,
Newest code review looks good to me.
-Drew
On 7/12/11 5:43 AM, William Schumann wrote:
Darren,
Thanks for the quick response.
I applied your suggestions and uploaded the revised webrev to:
http://cr.opensolaris.org/action/browse/caiman/wmsch/7065379-2/webrev/
Tested with and without ns1_convert method.
William
On 07/12/11 12:46 PM, Darren Kenny wrote:
Hi William,
Generally, the code looks fine, but I have some nits:
- In nameservice_info.py:
- line 165;
I think the import would be better done at the top of the file.
- lines 170-172:
I know this mechanism works, but it's quite unreadable, in that
it's hard
to know where the if/else code is in things.
I feel it would be more readable if the condition was around the
call to
setprop, or around the setting of a variable that is passed as
the last
argument.
Thanks,
Darren.
On 12/07/2011 11:23, William Schumann wrote:
http://cr.opensolaris.org/action/browse/caiman/wmsch/7065379/webrev/
Doug Leavitt has provided a Python method, ns1_convert, to access
the LDAP encryption function.
The code changes check for the existence of the ns1_convert
attribute prior to calling it. If ns1_convert is not integrated, the
user is prompted for the encrypted form. It is expected that
ns1_convert will be integrated in a week or two at most, so no further
guidance is provided to the user.
Python usage is as follows:
>>> import nss
>>> e = nss.nssscf.ns1_convert("foo")
>>> print e
{NS1}38eb23
>>> d = nss.nssscf.ns1_convert(e)
>>> print d
foo
Thank you,
William
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
