On Jul 14, 2011, at 5:05 PM, John Fischer wrote:
> Jesse,
>
> Looks good except for the print redirect to sys.stdout below:
>
> 330 print >> sys.stdout, cw(_("More than one IP address
> is "
> 331 "configured for use with "
> 332 "install services, using
> %s for "
> 333 "this service.") %
> server_ip)
Meant to use stderr there, fixed thanks!
> And shouldn't the $serverip be $serverIP?
>
> 337 server_ip = "$serverip"
Gah, yes. I did this webrev a bit on the fly, sorry :) My test file has
$serverIP, and my repo does as well.
Thanks!!
Jesse
>
>
> Thanks,
>
> John
> On 07/14/11 01:58 PM, Jesse Butler wrote:
>>
>>
>> Could I please get a review of my change for:
>>
>> 7066592
>> $serverIP can't be used for S11 Express images
>>
>> I mistakenly made a change in 170 that sets $serverIP for all install
>> images, but this cannot be done for Solaris 11 Express images because it
>> doesn't have support for this functionality. I actually didn't know at the
>> time we were shipping with support for S11 Express images, so I didn't even
>> test it.
>>
>> Now, I have. Here's the webrev, which I've already had one person take a
>> peek at.
>>
>> https://cr.opensolaris.org/action/browse/caiman/jesseb/7066592/webrev/
>>
>> Thanks
>> Jesse
>>
>>
>> _______________________________________________
>> caiman-discuss mailing list
>> [email protected]
>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
