Dermot,

Also please word wrap lines 742 and 832 in physical.py:

physical.py:742:80: E501 line too long (86 characters)
- summary, a 5 (or 7) line text string summary of the Disk's details. This is
                                                                               ^
physical.py:832:80: E501 line too long (101 characters)
vendor, device_label, device + "123456789012345678901234567890", bootdev_label, bootdev)

Thanks,

John

On 07/22/11 07:04 AM, Drew Fisher wrote:
Dermot,

Just two quick questions:

Is numpy in the standard python deployment? E.G. is it installed along with python-26?

Why the large string of numbers in Disk.get_details():832?

-Drew


On 7/22/11 7:54 AM, Dermot McCluskey wrote:
Hi,

Can I get a review for the following fixes for GUI Install:

7069280 gui-install cannot proceed if gnome-settings-daemon doesn't start up properly
7021433 Changes needed to GUI to add support for CRO information

Webrev:
https://cr.opensolaris.org/action/browse/caiman/dermot/cr_7069280_7021433/

7069280 - Check the return value when fetching disk icon
from Gnome; if it failed, then display a warning and create
out own, temp, blank icon
7021433 - add the Chassis and Receptacle details from croninfo
to the disk summary, if they are available


- Dermot


_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to