After further discussion in IRC, I've decided to close this CR as Not A
Defect rather than fix anything. We want to keep the debug messages in
place.
Thanks to Glenn and Karen for the discussion!
-Drew
On 8/1/11 4:15 PM, Drew Fisher wrote:
Good afternoon!
Could I please get a fast code review for
7071664 Target-instantiation generates unneeded errors when trying to
enable the write-cache
http://monaco.us.oracle.com/detail.jsf?cr=7071664
The fix is to simply remove the error message from being printed at
all. It's not a showstopper to fail to enable the write-cache and the
error message being printed is misleading.
diff -r 080fce7b6606 usr/src/lib/install_target/instantiation.py
--- a/usr/src/lib/install_target/instantiation.py Mon Aug 01
12:17:18 2011 +0800
+++ b/usr/src/lib/install_target/instantiation.py Mon Aug 01
16:07:13 2011 -0600
@@ -104,10 +104,9 @@
self.logger.debug("enabling write-cache on %s" %
disk.ctd)
number = C.c_int(1)
fcntl.ioctl(fd, DKIOCSETWCE, C.addressof(number))
- except Exception as err:
+ except Exception:
# ignore any errors generated by the ioctl
- self.logger.debug("unable to enable write-cache:")
- self.logger.debug(str(err))
+ pass
finally:
os.close(fd)
Thanks!
-Drew
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
