Hi Drew,
Thank you for the code review. Both of your
comments are accepted, and I put the changes
in the code.
Thanks,
--Karen
On 08/ 2/11 04:35 PM, Drew Fisher wrote:
Karen,
usr/src/cmd/text-install/disk_selection.py
------------------------------------------
373-375: one liner!
device = disk.receptacle or disk.ctd
501-502: combine into one line
Otherwise this looks good!
-Drew
On 8/2/11 4:18 PM, Karen Tung wrote:
Good afternoon,
Please review my changes for the following bugs:
7021428 <http://monaco.us.oracle.com/detail.jsf?cr=7021428> Changes
needed to Text Installer to add support for CRO information
7074171 <http://monaco.us.oracle.com/detail.jsf?cr=7074171> pep8
errors in terminalui/base_screen.py
7063642 <http://monaco.us.oracle.com/detail.jsf?cr=7063642>
system-config/profile/test/test_network_info.py unit test failure
after minilander putback.
webrev:
https://cr.opensolaris.org/action/browse/caiman/ktung/cro-info/webrev/
Thanks,
--Karen
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
