Matt, reviewed the wrong code - seems you uploaded the wrong thing... Will look again at the one you really wanted a review for here
Darren. On 26/08/2011 14:40, Darren Kenny wrote: > Hi Matt, > > Generally looking good, some comments (possibly nits): > > - progress_screen.py, line 284: > > I'm not 100% sure why things are pausing here, but I can't see any reason > that you wouldn't still pause before TARGET_INIT still. Maybe one of the > GUI guys who would be more aware of this code could confirm here. > > - text-install/ti_install.py, line 245: > > Similar comments to the above for the text installer... > > Thanks, > > Darren. > > On 26/08/2011 14:09, Matt Keenan wrote: >> Hi, >> >> Can I get a review and blessing for fix for : >> 7050547 ai_sd/aimdns unit tests failing on machine not configured as >> AI server >> http://monaco.sfbay.sun.com/detail.jsf?cr=7050547 >> >> Webrev: >> https://cr.opensolaris.org/action/browse/caiman/mattman/7050547/ >> >> >> Slim install unit tests tend to be run on a build machine which is not >> configured as an install server, thus these tests fail. Nose provides a >> SkipTest exception which when used will not report the tests themselves >> as failed. >> >> For ai_sd if multicast DNS SMF is not available then the tests will fail. >> >> For aimdns if install/server SMF is not available 5 tests will fail. >> >> I also discovered that when a service is removed, it remains advertised >> for a default time of 120 seconds, this results in time.sleep(120) calls >> being required for tests to be successful. >> >> cheers >> >> Matt >> _______________________________________________ >> caiman-discuss mailing list >> [email protected] >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
