On 08/25/11 09:37 AM, Shawn Walker wrote:
On 08/25/11 09:26, Jack Schwartz wrote:
Hi everyone.

Can I please get two reviews and Dave's blessing for:

7083337 Better text-mode-menu "Install Additional Drivers" temporary
handling until 7022551 is fixed

This review is for replacing the call to the DDU, which currently is not
delivered with the text installer images, with a "Not currently
implemented" message that displays for between 1 and 2 seconds.

webrev:
https://cr.opensolaris.org/action/browse/caiman/schwartz/7083337_1/webrev <https://cr.opensolaris.org/action/browse/caiman/schwartz/7083337_1>

bug report:
http://monaco.us.oracle.com/detail.jsf?cr=7083337

Tested by replacing the file on a running text-installer image and
restarting the install-setup service.

Can I ask why the menu item wasn't simply temporarily removed instead of giving the user a non-functional message?

-Shawn
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Hi Jack,

I agree with Shawn that it will be less confusing to just remove the menu item. I saw in your bug evaluation that you choose to fix it this way because you don't
want to break any existing tests that might rely on that option being there.
Can you check with QE to see how much effort it is for them to adjust their test suite?

On the bug, you also mention that DDU won't work in any live image. I see that the DDU icon is still delivered on the user's desktop, if it doesn't work, should we remove it from there? What about AI? What will happen if the user specified
DDU specific stuff on the AI manifest?

Thanks,

--Karen
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to