Drew, Looks good to me too.
John On Aug 29, 2011, at 5:09 PM, Mary Ding wrote: > Drew: > > LGTM and thank you for fixing this. > > > > On 08/29/11 04:58 PM, Drew Fisher wrote: >> >> Mary also wanted me to pick up >> >> 7083767 <http://monaco.us.oracle.com/detail.jsf?cr=7083767> extra >> usr/bin/sed in boot_archive_contents_x86.xml >> >> so the webrev has this now as well. >> >> -Drew >> >> >> >> On 8/29/11 5:53 PM, Drew Fisher wrote: >>> Good evening! >>> >>> Could I please get a code review for the following CR: >>> >>> 7083954 <http://monaco.us.oracle.com/detail.jsf?cr=7083954> >>> /usr/lib/devfsadm/linkmod/SUNW_audio_link.so should be removed from >>> boot*xml in snv_173 >>> >>> https://cr.opensolaris.org/action/browse/caiman/drewfish/7083954/webrev/ >>> >>> I tested this with both the AI manifest and liveCD manifest. >>> >>> AI: >>> ls -l >>> /rpool/cr_7083954/dc/ai/build_data/pkg_image/usr/lib/devfsadm/linkmod/SUNW_audio_link.so >>> >>> ls: cannot access >>> /rpool/cr_7083954/dc/ai/build_data/pkg_image/usr/lib/devfsadm/linkmod/SUNW_audio_link.so: >>> No such file or directory >>> >>> LiveCD: >>> ls -l >>> /rpool/cr_7083954/dc/livecd/build_data/pkg_image//usr/lib/devfsadm/linkmod/SUNW_audio_link.so >>> >>> -rwxr-xr-x 1 root sys 12764 Aug 29 15:48 >>> /rpool/cr_7083954/dc/livecd/build_data/pkg_image//usr/lib/devfsadm/linkmod/SUNW_audio_link.so* >>> >>> (this is what we want) >>> >>> Grepping for "Errno" from the detail-log: >>> >>> AI: >>> [mox:logs] > grep Errno detail-log.2011-08-29.15\:37 >>> [mox:logs] > echo $? >>> 1 >>> >>> >>> LiveCD: >>> [mox:logs] > grep Errno detail-log.2011-08-29.15\:28 >>> [mox:logs] > echo $? >>> 1 >>> >>> (this is what we want) >>> >>> >>> Thanks! >>> >>> -Drew >>> >>> >>> _______________________________________________ >>> caiman-discuss mailing list >>> [email protected] >>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >> >> >> _______________________________________________ >> caiman-discuss mailing list >> [email protected] >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss > > _______________________________________________ > caiman-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
