LGTM too. Darren.
On 30/08/2011 15:45, Sue Sohn wrote: > Matt, > > Looks ok now. > > Sue > > On 08/30/11 02:56, Matt Keenan wrote: >> Thanks Sue, >> >> Updated README. >> >> New webrev posted : >> https://cr.opensolaris.org/action/browse/caiman/mattman/7050547/ >> >> cheers >> >> Matt >> >> >> On 08/29/11 16:40, Sue Sohn wrote: >>> Hi Matt, >>> >>> The README has this new line: >>> auto-install/manualtest: cmd/auto-install/manualtest >>> >>> but the manual tests appear to be in: >>> cmd/auto-install/test/manual >>> and >>> cmd/installadm/test/manual >>> >>> Sue >>> >>> On 08/26/11 10:13, Matt Keenan wrote: >>>> Hi, >>>> >>>> Re-Worked webrev now posted to ; >>>> https://cr.opensolaris.org/action/browse/caiman/mattman/7050547/ >>>> >>>> This webrev contains : >>>> >>>> - Splitting out tests that require 120 second timeouts to be manual tests, >>>> and leaving >>>> all other tests intact. >>>> >>>> - Calling check_install_SMF() at init time where it makes sense. >>>> >>>> cheers >>>> >>>> Matt >>>> >>>> On 08/26/11 14:09, Matt Keenan wrote: >>>>> Hi, >>>>> >>>>> Can I get a review and blessing for fix for : >>>>> 7050547 ai_sd/aimdns unit tests failing on machine not configured as AI >>>>> server >>>>> http://monaco.sfbay.sun.com/detail.jsf?cr=7050547 >>>>> >>>>> Webrev: >>>>> https://cr.opensolaris.org/action/browse/caiman/mattman/7050547/ >>>>> >>>>> >>>>> Slim install unit tests tend to be run on a build machine which is not >>>>> configured as an install >>>>> server, thus these tests fail. Nose provides a SkipTest exception which >>>>> when used will not report >>>>> the tests themselves as failed. >>>>> >>>>> For ai_sd if multicast DNS SMF is not available then the tests will fail. >>>>> >>>>> For aimdns if install/server SMF is not available 5 tests will fail. >>>>> >>>>> I also discovered that when a service is removed, it remains advertised >>>>> for a default time of 120 >>>>> seconds, this results in time.sleep(120) calls being required for tests >>>>> to be successful. >>>>> >>>>> cheers >>>>> >>>>> Matt >>>>> _______________________________________________ >>>>> caiman-discuss mailing list >>>>> [email protected] >>>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >>>> >>>> _______________________________________________ >>>> caiman-discuss mailing list >>>> [email protected] >>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >>> >> > > _______________________________________________ > caiman-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
