Cool, that's much better. Approved, pending your reviewers' satisfaction.
Dave
On 08/31/11 10:01, Darren Kenny wrote:
An example, where I called the package 'entirity' rather than 'entire' would
give me:
14:04:02 Failed Checkpoints:
14:04:02
14:04:02 ips
14:04:02
14:04:02 Checkpoint execution error:
14:04:02
14:04:02 The following pattern(s) did not match any allowable packages.
Try
14:04:02 using a different matching pattern, or refreshing publisher
information:
14:04:02
14:04:02 pkg:/entirity
14:04:02
14:04:02 Automated Installation Failed. See install log at
/system/volatile/install_log
Darren.
On 31/08/2011 14:50, Dave Miner wrote:
What does the output now look like for the cases where we run into these
problems, such as the recent rash of 'Error occurred during
execution...' reports?
Dave
On 08/31/11 09:46, Darren Kenny wrote:
Hi,
Could I please get a code review, and approval for the simple fix which
addresses both of the following issues:
7084504 AI should report IPS errors to the tty/console
7041581 Install Engine should be called with debug=False
The webrev is at:
https://cr.opensolaris.org/action/browse/caiman/dkenny/7084504-7041581/webrev/
The reason that the error isn't being correctly logged is down to exceptions
traveling all the way from the checkpoint to the initial main code, by passing
normal logging.
The fix is to remove the setting of the debug flag when executing the
checkpoints, which means that the engine will then catch the exception, and
store it in the error service.
AI will then do the right thing an log that error.
I've tested complete installs, and injected some errors too to ensure that
things were working as expected.
Thanks,
Darren.
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
