Thanks Darren, for replying (somehow I didn't receive Keith's mail).
Sue

On 08/31/11 06:57, Darren Kenny wrote:
On 30/08/2011 23:06, Keith Mitchell wrote:
lines 318-321: Isn't that handled and saved as "config_file" on lines 241-245?
The final path being /tmp/$config_file based on line 252?

Hi Keith,

I don't believe that code at lines 241-245 will handle it as we would like here.

At those lines it either sets it to "" or install.conf - which in turn
influences whether to down load the file at lines 248-262. As such we couldn't
set it to be system.conf here either.

I believe that Susan's fix is more appropriate for the way we wish things to
behave here.

LGTM Susan,

Thanks,

Darren.


On Tue, Aug 30, 2011 at 2:33 PM, Sue Sohn<[email protected]
<mailto:[email protected]>>  wrote:

     Can I get a couple of reviews of the changes for:

     7085106 livessh=enable is ignored in system.conf file

     Webrev:
     
https://cr.opensolaris.org/__action/browse/caiman/sohn/__7085106/webrev.7085106
     
<https://cr.opensolaris.org/action/browse/caiman/sohn/7085106/webrev.7085106>

     Thanks,
     Sue

     _________________________________________________
     caiman-discuss mailing list
     [email protected]<mailto:[email protected]>
     http://mail.opensolaris.org/__mailman/listinfo/caiman-__discuss
     <http://mail.opensolaris.org/mailman/listinfo/caiman-discuss>




--
Join me in the fight to end AIDS!
http://www.tofighthiv.org/goto/kemitche


_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to